[ENH] Add line breaks in _episodes/03-lists #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-belkin
suggested changes
Jul 17, 2018
There was a problem hiding this comment.
Thanks for your contribution, @emdupre! Please see my comments below (above?) :)
_episodes/03-lists.md
Outdated
| > the list value, it will change for both variables! | ||
| > Be careful when modifying data in-place. | ||
| > If two variables refer to the same list, and you modify the list value, | ||
| > it will change for both variables! |
There was a problem hiding this comment.
Let's keep all the lines above unchanged. They do not exceed the 100-character limit.
_episodes/03-lists.md
Outdated
| @@ -173,7 +175,8 @@ does not. | |||
| > Here is a visual example of how indexing a list of lists `x` works: | |||
| > | |||
| > <a href='https://twitter.com/hadleywickham/status/643381054758363136'> | |||
| > </a> | |||
| >  | |||
| > </a> | |||
There was a problem hiding this comment.
Let's rewrite this link in Markdown.
[][hadleywickham-tweet]
And add the following to the bottom of the document:
[hadleywickham-tweet]: https://twitter.com/hadleywickham/status/643381054758363136
| @@ -214,7 +217,7 @@ does not. | |||
|
|
|||
| > ## Heterogeneous Lists | |||
| > Lists in Python can contain elements of different types. Example: | |||
| > ~~~ | |||
| > ~~~ | |||
| @@ -539,4 +539,6 @@ Omitting ending index: ["sep", "oct", "nov", "dec"] | |||
| > {: .solution} | |||
| {: .challenge} | |||
|
|
|||
| [hadleywickham-tweet]: https://twitter.com/hadleywickham/status/643381054758363136 | |||
|
|
|||
| {% include links.md %} | |||
There was a problem hiding this comment.
Thanks! Was about to add a comment about it :)
_episodes/03-lists.md
Outdated
| > <a href='https://twitter.com/hadleywickham/status/643381054758363136'> | ||
| > </a> | ||
| > [][hadleywickham-tweet] |
There was a problem hiding this comment.
I know this does not change much, but let's add > in the beginning of this line.
| @@ -539,4 +539,6 @@ Omitting ending index: ["sep", "oct", "nov", "dec"] | |||
| > {: .solution} | |||
| {: .challenge} | |||
|
|
|||
| [hadleywickham-tweet]: https://twitter.com/hadleywickham/status/643381054758363136 | |||
There was a problem hiding this comment.
Let's use this link on line 211 as well.
maxim-belkin
approved these changes
Jul 17, 2018
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps to address #498, following up on #565 !
Changes proposed: