Skip to content

refactor(es/typescript): Extract type annotation proposal out #9127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2024
Merged

refactor(es/typescript): Extract type annotation proposal out #9127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccbe892
use
kdy1 Jul 3, 2024
bb7eab7
fmt
kdy1 Jul 3, 2024
90e0d5e
Expose StripType
kdy1 Jul 3, 2024
98e7960
strip_type
kdy1 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions bindings/binding_typescript_wasm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,14 @@ use swc_core::{
parser::{
parse_file_as_module, parse_file_as_program, parse_file_as_script, Syntax, TsSyntax,
},
transforms::base::{
fixer::fixer,
helpers::{inject_helpers, Helpers, HELPERS},
hygiene::hygiene,
resolver,
transforms::{
base::{
fixer::fixer,
helpers::{inject_helpers, Helpers, HELPERS},
hygiene::hygiene,
resolver,
},
typescript::strip_type,
},
visit::VisitMutWith,
},
Expand Down Expand Up @@ -52,9 +55,8 @@ pub struct Options {
#[serde(default)]
pub source_maps: bool,

#[serde(default)]
pub transform: swc_core::ecma::transforms::typescript::Config,

// #[serde(default)]
// pub transform: swc_core::ecma::transforms::typescript::Config,
#[serde(default)]
pub codegen: swc_core::ecma::codegen::Config,
}
Expand Down Expand Up @@ -148,10 +150,7 @@ fn operate(input: String, options: Options) -> Result<TransformOutput, Error> {

// Strip typescript types

program.visit_mut_with(&mut swc_core::ecma::transforms::typescript::typescript(
options.transform,
top_level_mark,
));
program.visit_mut_with(&mut strip_type());

// Apply external helpers

Expand Down
2 changes: 1 addition & 1 deletion crates/swc_ecma_transforms_typescript/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#![allow(clippy::vec_box)]
#![allow(clippy::mutable_key_type)]

pub use self::typescript::*;
pub use self::{strip_type::*, typescript::*};
mod config;
mod macros;
mod strip_import_export;
Expand Down
4 changes: 4 additions & 0 deletions crates/swc_ecma_transforms_typescript/src/strip_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ use swc_ecma_visit::{VisitMut, VisitMutWith};

use crate::{type_to_none, unreachable_visit_mut_type};

pub fn strip_type() -> impl VisitMut {
StripType::default()
}

/// This Module will strip all types/generics/interface/declares
/// and type import/export
#[derive(Default)]
Expand Down