Skip to content

test(ts/fast-strip): Add tests for declare module error cases #10040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

test(ts/fast-strip): Add tests for declare module error cases #10040

merged 1 commit into from
Feb 17, 2025
+56 −1

Conversation

@magic-akari
Copy link
Member

@magic-akari magic-akari commented Feb 16, 2025

@magic-akari magic-akari requested a review from a team as a code owner February 16, 2025 06:41
@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2025

⚠️ No Changeset found

Latest commit: d2f441f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title fix(ts/fast-strip): Add tests for declare module error cases test(ts/fast-strip): Add tests for declare module error cases Feb 17, 2025
@kdy1 kdy1 added this to the Planned milestone Feb 17, 2025
@kdy1 kdy1 merged commit 37672e0 into swc-project:main Feb 17, 2025
170 of 171 checks passed
@magic-akari magic-akari deleted the type-strip/test-case branch February 17, 2025 07:51
@kdy1 kdy1 modified the milestones: Planned, v1.10.17 Feb 18, 2025
marco-ippolito
marco-ippolito reviewed Feb 18, 2025
View reviewed changes
bindings/binding_typescript_wasm/__tests__/__snapshots__/transform.js.snap
`;
exports[`transform in transform mode should throw an error when it encounters a declared module 1`] = `
" x \`module\` keyword is not supported. Use \`namespace\` instead.
Copy link
Contributor

@marco-ippolito marco-ippolito Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magic-akari @kdy1 its missing the error code "Unsupported Syntax" in transform mode
nodejs/amaro#177

@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kdy1 kdy1 kdy1 approved these changes

+1 more reviewer

@marco-ippolito marco-ippolito marco-ippolito left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

v1.10.17

Development

Successfully merging this pull request may close these issues.

3 participants

@magic-akari @kdy1 @marco-ippolito