Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support compile js files. close #761 #767

Merged
merged 3 commits into from
May 1, 2024

Conversation

yeliex
Copy link
Contributor

@yeliex yeliex commented Apr 10, 2024

Currently swc-register only transpile .tsx? files. But @swc/core supports both .js and .ts files. It is necessary to transpile both file types to align behavior with @swc/core because of features like path alias and others in some cases.

Additionally:

  1. because of fix(es/module): Fix jsc.paths with resolveFully swc#8784 we should update @swc/core to the latest version. So this should be a minor semver
  2. update node esm module hook API definition to node:module

close #761

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: c47505b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Apr 10, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@swc/core@1.3.107

View full report↗︎

@yeliex yeliex marked this pull request as draft April 10, 2024 02:45
@yeliex yeliex force-pushed the fix/js-module branch 3 times, most recently from 6d19abe to ddc3971 Compare April 10, 2024 06:33
@yeliex yeliex changed the title fix: support compile js files in esm projects. close #761 fix: support compile js files. close #761 Apr 10, 2024
@yeliex
Copy link
Contributor Author

yeliex commented Apr 10, 2024

@Brooooooklyn @stelescuraul please take a look.

It changed some behavior but should be compatible with old versions.

@yeliex yeliex marked this pull request as ready for review April 10, 2024 08:09
@Brooooooklyn Brooooooklyn merged commit 016f1aa into swc-project:master May 1, 2024
7 checks passed
@yeliex
Copy link
Contributor Author

yeliex commented May 1, 2024

#769 #765 could be closed as well @Brooooooklyn

tsang-bot bot referenced this pull request in tsangste/nx-package-test May 5, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@swc-node/register](https://togithub.com/swc-project/swc-node) |
[`1.9.0` ->
`1.9.1`](https://renovatebot.com/diffs/npm/@swc-node%2fregister/1.9.0/1.9.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@swc-node%2fregister/1.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@swc-node%2fregister/1.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@swc-node%2fregister/1.9.0/1.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@swc-node%2fregister/1.9.0/1.9.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>swc-project/swc-node (@&#8203;swc-node/register)</summary>

###
[`v1.9.1`](https://togithub.com/swc-project/swc-node/releases/tag/%40swc-node/register%401.9.1)

[Compare
Source](https://togithub.com/swc-project/swc-node/compare/@swc-node/register@1.9.0...@swc-node/register@1.9.1)

#### What's Changed

- fix: esm module resolve issues by
[@&#8203;yeliex](https://togithub.com/yeliex) in
[https://github.com/swc-project/swc-node/pull/754](https://togithub.com/swc-project/swc-node/pull/754)
- fix: add default tsconfig.baseUrl to align with tsc behavior by
[@&#8203;yeliex](https://togithub.com/yeliex) in
[https://github.com/swc-project/swc-node/pull/759](https://togithub.com/swc-project/swc-node/pull/759)
- fix(register): fix esm entry resolver for third-party executer, close
[#&#8203;762](https://togithub.com/swc-project/swc-node/issues/762) by
[@&#8203;yeliex](https://togithub.com/yeliex) in
[https://github.com/swc-project/swc-node/pull/766](https://togithub.com/swc-project/swc-node/pull/766)
- fix: support compile js files. close
[#&#8203;761](https://togithub.com/swc-project/swc-node/issues/761) by
[@&#8203;yeliex](https://togithub.com/yeliex) in
[https://github.com/swc-project/swc-node/pull/767](https://togithub.com/swc-project/swc-node/pull/767)
- chore: upgrade dependencies by
[@&#8203;Brooooooklyn](https://togithub.com/Brooooooklyn) in
[https://github.com/swc-project/swc-node/pull/771](https://togithub.com/swc-project/swc-node/pull/771)

**Full Changelog**:
https://github.com/swc-project/swc-node/compare/[@&#8203;swc-node/register](https://togithub.com/swc-node/register)[@&#8203;1](https://togithub.com/1).8.0...[@&#8203;swc-node/register](https://togithub.com/swc-node/register)[@&#8203;1](https://togithub.com/1).9.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuNiIsInVwZGF0ZWRJblZlciI6IjM3LjM0MC42IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: tsang-bot[bot] <146107447+tsang-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Path aliases not working on ESM modules
2 participants