Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): assign baseUrl property #723

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(core): assign baseUrl property #723

merged 1 commit into from
Aug 18, 2023

Conversation

kawaemon
Copy link
Contributor

#721 did declare baseUrl property, but did not assign that.

This PR fixes it to fix problems something like:
failed to handle: base_dir() must be absolute. Please ensure that jsc.baseUrl is specified correctly.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kawaemon
Copy link
Contributor Author

@Brooooooklyn
Would you please review this PR again?

@Brooooooklyn Brooooooklyn merged commit c229b54 into swc-project:master Aug 18, 2023
5 checks passed
@kawaemon
Copy link
Contributor Author

thanks!

@kawaemon kawaemon deleted the pass-baseurl branch August 18, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kawaemon @CLAassistant @Brooooooklyn