Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show devices that enable commands #899

Merged
merged 2 commits into from
Dec 14, 2022
Merged

show devices that enable commands #899

merged 2 commits into from
Dec 14, 2022

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Dec 11, 2022

fixes #788

@kostmo
Copy link
Member Author

kostmo commented Dec 11, 2022

Screenshot from 2022-12-10 23-56-49

@kostmo kostmo requested a review from byorgey December 11, 2022 08:07
byorgey
byorgey approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic. I like that it only shows you devices you actually have or know about.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Dec 14, 2022
@mergify mergify bot merged commit 9c06024 into main Dec 14, 2022
@mergify mergify bot deleted the devices-for-commands branch December 14, 2022 04:11
@kostmo kostmo mentioned this pull request Jan 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include known device(s) that provide commands in command help dialog
2 participants
@kostmo @byorgey