-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: allow enum ordered const name override #1779
base: master
Are you sure you want to change the base?
Feat: allow enum ordered const name override #1779
Conversation
@drewsilcock Please rebase and update the code. |
1443dbf
to
61ef538
Compare
Thanks for taking the time to take a look at this @ubogdan - I've rebased and updated based on the linter and your comments. |
I can't see the passed checks of all the tests. |
Is there something additional we need to do for the full test suite to run on this PR? (The tests pass just fine when I run it locally on Go v1.22.) |
@ubogdan was requested to review。 |
Thanks for approving, I re-requested a review from @ubogdan after making the changes he requested, is his approval required for merging? GitHub seems to be blocking merge until the review request is approved or dismissed. |
Describe the PR
Add ability to override name of enum variant generated from ordered constant using
// @name VariantName
in the same way you can do for types.Relation issue
#1778
Additional context
N/A