Don't configure the parent with allOf #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
added a commit
to cbornet/swagger-codegen
that referenced
this pull request
May 30, 2016
If a composed model (allOf) doesn't have any parent and one of its interface has a discriminator field, then set this interface as parent. See swagger-api#2096 See swagger-api/swagger-parser#246
|
+1 |
|
rebased to resolve conflict. |
|
@fehguy Thanks for merging 👍 ! |
|
@cbornet very close, this is required for the codegen release, which we (and you!) are working on. |
cbornet
added a commit
to cbornet/swagger-codegen
that referenced
this pull request
Jul 15, 2016
If a composed model (allOf) doesn't have any parent and one of its interface has a discriminator field, then set this interface as parent. See swagger-api#2096 See swagger-api/swagger-parser#246
fehguy
pushed a commit
to swagger-api/swagger-codegen
that referenced
this pull request
Jul 17, 2016
If a composed model (allOf) doesn't have any parent and one of its interface has a discriminator field, then set this interface as parent. See #2096 See swagger-api/swagger-parser#246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #245