Merge pull request #1312 from GORA-SAG/issue1249

gracekarina · web-flow · commit 64fa4e67b522 · 2020-02-07T09:10:20.000-05:00
Fix for issue #1249
diff --git a/modules/swagger-parser/src/main/java/io/swagger/parser/util/SwaggerDeserializer.java b/modules/swagger-parser/src/main/java/io/swagger/parser/util/SwaggerDeserializer.java
@@ -125,6 +125,9 @@ public Swagger parseRoot(JsonNode node, ParseResult result) {
                     JsonNode paramNode = obj.get(key);
                     if (paramNode instanceof ObjectNode) {
                         Parameter parameter = this.parameter((ObjectNode) paramNode, location, result);
+                        if ("path".equalsIgnoreCase(parameter.getIn()) && !parameter.getRequired()) {
+                            result.warning(location + ".'" + parameter.getName() + "'", " For path parameter '" + parameter.getName() + "' the required value should be true");
+                        }
                         parameters.put(key, parameter);
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,9 @@ public Swagger parseRoot(JsonNode node, ParseResult result) {`
`125`	`125`	`JsonNode paramNode = obj.get(key);`
`126`	`126`	`if (paramNode instanceof ObjectNode) {`
`127`	`127`	`Parameter parameter = this.parameter((ObjectNode) paramNode, location, result);`
	`128`	`+ if ("path".equalsIgnoreCase(parameter.getIn()) && !parameter.getRequired()) {`
	`129`	`+ result.warning(location + ".'" + parameter.getName() + "'", " For path parameter '" + parameter.getName() + "' the required value should be true");`
	`130`	`+ }`
`128`	`131`	`parameters.put(key, parameter);`
`129`	`132`	`}`
`130`	`133`	`}`