Skip to content

feat: replace required attribute on @Schema by requiredMode #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: replace required attribute on @Schema by requiredMode #4221

wants to merge 2 commits into from

Conversation

@nvervelle
Copy link
Contributor

@nvervelle nvervelle commented Jul 20, 2022 •
edited
Loading

Add a property requiredMode on @Schema annotations that allows deciding if the heuristics on annotations like @NotNull should apply, so we can have a property annotated @NotNull but still have required = false in the openapi spec.

This is a second proposal for issue #4213, other proposal was #4216

@nvervelle
feat: replace required attribute on @Schema by requiredMode
e2fd693 
Add a property requiredMode on @Schema annotations that allows deciding if the heuristics on annotations like @NotNull should apply, so we can have a property annotated @NotNull but still have required = false in the openapi spec
@nvervelle nvervelle mentioned this pull request Jul 20, 2022
Closed
@frantuma frantuma mentioned this pull request Nov 2, 2022
Merged
@frantuma
Copy link
Contributor

frantuma commented Nov 2, 2022

Thanks a lot!

Included in and replaced by #4286

@frantuma frantuma closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nvervelle @frantuma