Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop 2.0] consider removing scala as test dependency #804

Closed
fehguy opened this issue Dec 23, 2014 · 8 comments
Closed

[develop 2.0] consider removing scala as test dependency #804

fehguy opened this issue Dec 23, 2014 · 8 comments
Milestone

Comments

@fehguy
Copy link
Contributor

fehguy commented Dec 23, 2014

The tests are much easier to write with scala + scalatest, but it may be friendlier to developers to remove that and move to a pure java test framework.

@fehguy fehguy added the Feature label Dec 23, 2014
@fehguy fehguy added this to the v1.5.0-M1 milestone Dec 23, 2014
@fehguy fehguy added the P3 label Dec 23, 2014
@adrianbk
Copy link
Contributor

@fehguy
Copy link
Contributor Author

fehguy commented Dec 23, 2014

Will definitely take a look. I get dizzy just thinking about going back to pure junit assertions.

@webron
Copy link
Contributor

webron commented Dec 24, 2014

Umm, definitely not junit. If anything TestNG. Spock is probably worth looking at.

@fehguy
Copy link
Contributor Author

fehguy commented Jan 20, 2015

I'm not going to do this for M1, will push to M2 and reconsider then.

@fehguy fehguy modified the milestones: v1.5.0-M2, v1.5.0-M1 Jan 20, 2015
@martoe
Copy link

martoe commented Jan 20, 2015

+1 for spock - a great tool for writing simple yet expressive tests

@fehguy fehguy modified the milestones: v1.5-M2, v1.5-M3 Mar 12, 2015
@webron webron modified the milestones: v1.5-M3, v1.5 May 4, 2015
@webron webron modified the milestones: v1.5, v1.5.1 Jun 8, 2015
@t1
Copy link
Contributor

t1 commented Jul 10, 2015

Spoc is nice, but it requires Groovy, which is also fine, but poses the same downside as scalatest requiring Scala.

I recently stumbled over assertj and started to use it in some of my projects. It makes writing very good assertions really easy. IMHO, using this makes a bigger difference than using TestNG of JUnit.

@webron
Copy link
Contributor

webron commented Jul 10, 2015

Well, we decided to go with TestNG for now.

@t1
Copy link
Contributor

t1 commented Jul 10, 2015

TestNG is great, and assertj augments it nicely :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants