Skip to content

generate erlang code after opt processing #8049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liamjjmcnamara
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This is a fix for Issue 8084

I extended the processOpts() method in ErlangServerCodegen.java to contain the (already existing) calls to supportingFiles.add, effectively moving them from the constructor. This causes the supportingFiles.add calls to happen after option processing, and thus causes the code to respect the setting of --additional-properties packageName on the commandline.

@tsloughter

@wing328
Copy link
Contributor

wing328 commented Apr 21, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

petstore sample update
@liamjjmcnamara
Copy link
Author

Ah, thanks for catching that, I squashed the commits and relabeled.

@liamjjmcnamara
Copy link
Author

CI pipeline is failing, but seemingly due to network failures upsetting sbt downloads, rather than failing tests.

@solvip
Copy link

solvip commented May 18, 2018

Is there anything stopping this from being merged?

colrack pushed a commit to colrack/swagger-codegen that referenced this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants