[Swift4] accept empty content with default client#7921
Merged
wing328 merged 3 commits intoswagger-api:masterfrom Apr 6, 2018
Merged
[Swift4] accept empty content with default client#7921wing328 merged 3 commits intoswagger-api:masterfrom
wing328 merged 3 commits intoswagger-api:masterfrom
Conversation
Contributor
|
+1 We've actually been doing this, but didn't want to do a breaking change! What do the others think? |
Contributor
|
@jgavris I think it's ok to add this as a breaking change to 3.0.0 which already has a lot of other breaking changes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
To fix #7850, we accept
Voidresponse as empty body. This behavior is same asPromiseKitandRxSwiftresponseBreaking Change
By merging this PR, for using
defaultclient users, they need to change response as follow warnings by compiler.Before:
After:
or you can ignore response as below.