[Typescript Fetch] Multiple enhancements #7914
Conversation
Support new esnext syntax for modules Fix issue to support typescript 2.7
| @@ -431,7 +431,7 @@ public String toEnumValue(String value, String datatype) { | |||
| if ("number".equals(datatype)) { | |||
| return value; | |||
| } else { | |||
| return "\'" + escapeText(value) + "\'"; | |||
| return "\"" + escapeText(value) + "\""; | |||
There was a problem hiding this comment.
I wouldn't change it to double quotes. instead, #7369 should be fixed
There was a problem hiding this comment.
Ok I will rollback this part. I was following the advice of my pro typescript teammate here but I guess it doesn't matter :)
Will provide a new version sometime this morning.
Thanks!
|
If no further question/feedback on this PR, I'll merge it tomorrow (Friday) |
|
Linking issue #8180 The changes supported here will resolve issues I am having compiling for strict Typescript 2.4 |
|
Are there any updates on this PR? Or is it dead? |
|
@msiemens I have cloned this PR in a fork of this project, here: OpenAPITools/openapi-generator#145 Check it out if you want :) |
|
Hi @wing328 - I found this PR through #8180 from @fungus1487. I get the same TypeScript compilation errors (TypeScript v3.0.3) because properties are not initialized, and they would be fixed by this PR. Can I make the same changes and open a new PR, to hopefully get past the failing checks? |
|
@jackkoppa in the meantime, OpenAPITools/openapi-generator#145 has been merged, so you should be able to generate the fixed code with the latest OpenAPI Generator |
|
Hey @jackkoppa, if you're willing to create the PR, feel free to do it and ping me there. i can help you to get your changes merged. |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01)
Description of the PR
Add support for string enums
Support new esnext syntax for modules
Fix issue to support typescript 2.4 +
Not sure if it triggers breaking changes. If so, just let me know on which branch I should create this PR. Thanks!