Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Visual Studio Project GUID #7665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix for Visual Studio Project GUID #7665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/swagger-codegen/src/main/resources/aspnetcore/Solution.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Visual Studio 15
VisualStudioVersion = 15.0.26114.2
MinimumVisualStudioVersion = 10.0.40219.1
Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "{{packageName}}", "src\{{packageName}}\{{packageName}}.csproj", "{{packageGuid}}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "{{packageName}}", "src\{{packageName}}\{{packageName}}.csproj", "{{packageGuid}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will have to be conditional based on some flag. We support Xamarin Studio (Visual Studio on Mac, now) as well as Rider.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, most frustrating part is VS just fails with no real indication of why it couldn't load the project. Maybe the documentation can be updated to let others know about this issue?

thanks for looking into it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about generating 2 solutions files for Xamarin and VS Studio respectively? e.g.

IO.Swagger.xamarin.sln
IO.Swagger.vs.sln

Developers can open the one based on their preference.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if that's a good approach as it could be very confusing which to open in other editors like VS Code or Rider.

Because this is dependent on VS 2017, I think it would make sense to switch on that, as there's been discussion about other VS 2017 issues. Or, if there's a project version in the new sln format, that would be ideal, because that format would likely be used for multiple future versions of VS. That is, passing vs=2017 then opening in VS 2019 could be confusing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making the project GUID itself a option to be passed in?

EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down