Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ada] Fix GNAT project and server skeleton to avoid sending a response when an error is returned #7574

Merged
merged 4 commits into from
Feb 5, 2018

Conversation

stcarrez
Copy link
Contributor

@stcarrez stcarrez commented Feb 4, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The GNAT project that allows to build the samples must now be based on the 'servlet' project and not 'asf' because 'servlet' project is a light version of 'asf'. The 'servlet' project is also not necessary when we build the Ada client, hence we can omit its inclusion in that case.

Updated the server configuration properties for the server to describe the OAuth2 allowed applications and users.

The server skeleton must not emit a JSON/XML response if the server operation returned a response other than 200. Otherwise, we also send some possibly spurious content together with a 204 response for example.

@wing328 wing328 added this to the v2.4.0 milestone Feb 5, 2018
@wing328 wing328 merged commit 9ba74f4 into swagger-api:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants