cpprest : Fix Eve Online ESI. #7571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest commit fixes : #7572 Renaming to more general intention of PR. |
p-groarke
changed the title
3 tasks
etherealjoy
reviewed
Mar 11, 2018
| content->setContentType( contentType ); | ||
| std::stringstream* valueAsStringStream = new std::stringstream(); | ||
| (*valueAsStringStream) << json_array; | ||
| content->setData( std::shared_ptr<std::istream>( valueAsStringStream ) ); |
There was a problem hiding this comment.
Here is missing the encoding conversion
etherealjoy
reviewed
Mar 11, 2018
| content->setContentType( contentType ); | ||
| std::stringstream* valueAsStringStream = new std::stringstream(); | ||
| (*valueAsStringStream) << json_array; | ||
| content->setData( std::shared_ptr<std::istream>( valueAsStringStream ) ); |
There was a problem hiding this comment.
Here is missing the encoding conversion
etherealjoy
reviewed
Mar 11, 2018
| if({{paramName}}.get()) | ||
| }{{/isListContainer}} | ||
| {{^isListContainer}}{{#isString}}multipart->add(ModelBase::toHttpContent(utility::conversions::to_string_t("{{paramName}}"), {{paramName}})); | ||
| {{/isString}}{{^isString}}if({{^required}}{{paramName}} && {{/required}}{{paramName}}.get()) |
There was a problem hiding this comment.
if({{^required}}{{paramName}} && {{/required}}{{paramName}}.get())
isn't paramName a pointer here? when ^required?
|
A month too late ;) |
|
Ahh no problems, I can take your changes and integrate with another PR if you have no objection. |
|
@etherealjoy Please do! The recursive vector stuff should be useful at minimum. Cheers |
4 tasks
This was referenced Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Cumulative fixes for api : https://esi.tech.ccp.is/latest/swagger.json
#7100
@etherealjoy As discussed in the issue.