Add auto-generated Lua spec files for APIs, models #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
reviewed
Feb 2, 2018
|
|
||
| ]] | ||
|
|
||
| local petstore_category = require "petstore.model.category" |
There was a problem hiding this comment.
Usually I put this require inside of the describe. That way if you're only running some tests or mocking out something, it won't require it too early.
daurnimator
reviewed
Feb 2, 2018
| Contact: apiteam@swagger.io | ||
| Generated by: https://github.com/swagger-api/swagger-codegen.git | ||
| Swagger Codegen version: 2.4.0-SNAPSHOT | ||
|
|
| -- TODO assertion here: http://olivinelabs.com/busted/#asserts | ||
| end) | ||
| end) | ||
|
|
| //} | ||
| @Override | ||
| public String apiTestFileFolder() { | ||
| return outputFolder + File.separator + apiPackage + File.separator + specFolder.replace("/", File.separator); |
There was a problem hiding this comment.
The spec folder should be at the top level (same level as e.g. the rockspec)
|
@daurnimator thanks for the feedback. I'll address it over the weekend. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Add auto-generated Lua spec files for APIs, models
cc @daurnimator