Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Fix Rockpec #7554

Merged
merged 2 commits into from
Feb 2, 2018
Merged

[Lua] Fix Rockpec #7554

merged 2 commits into from
Feb 2, 2018

Conversation

wing328
Copy link
Contributor

@wing328 wing328 commented Feb 2, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

For #7475 (review)

cc @daurnimator

@wing328 wing328 added this to the v2.4.0 milestone Feb 2, 2018
Copy link
Contributor

@daurnimator daurnimator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wing328
Copy link
Contributor Author

wing328 commented Feb 2, 2018

@daurnimator thanks for reviewing. I'll merge it once all CI tests pass.

@wing328 wing328 merged commit 38a2c1d into master Feb 2, 2018
@wing328 wing328 deleted the lua_fix_rockspec branch February 2, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants