Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ada] changed default project/package name, to solve circular dependencies #7550

Merged
merged 7 commits into from
Feb 2, 2018
Merged

[Ada] changed default project/package name, to solve circular dependencies #7550

merged 7 commits into from
Feb 2, 2018

Conversation

michelealbano
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix #7543.
Changed the default project name and package name for the Ada language, not to have circular dependencies when using default project/package names.

@wing328
Copy link
Contributor

wing328 commented Feb 2, 2018

@micheleISEP thanks for the PR.

cc @stcarrez for review.

@stcarrez
Copy link
Contributor

stcarrez commented Feb 2, 2018

Looks good for me.

@wing328 wing328 merged commit ea27924 into swagger-api:master Feb 2, 2018
@wing328 wing328 added this to the v2.4.0 milestone Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants