[Java] Fixed @Deprecated annotations #6801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2, okhttp-gson, resteasy libraries
|
LGTM |
|
@brian-byungsookim thanks for the PR, which has been merged into master. I also did a case-insensitive grep on other Java generator (e.g. server) and confirmed there's no other references to |
|
From what I can tell, this doesn't address deprecated properties within models. Is that by design? |
|
Sorry for the late response, but yes, I didn't address deprecated models in this PR. |
|
@martypitt may I know if you've time to file a PR to address deprecated properties within models? |
|
Unfortunately no. The underlying problem is that the swagger model jar
doesn't support deprecated property attributes in the current version,
making it a non-starter.
…On Wed, 22 Nov 2017, 09:15 William Cheng, ***@***.***> wrote:
@martypitt <https://github.com/martypitt> may I know if you've time to
file a PR to address deprecated properties within models?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6801 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVStNuZin57P-N_FNOtBwbOMamsV-3Tks5s4-ZAgaJpZM4QFAU1>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fixed a previous PR (#6166) by adding the
@Deprecatedannotation to appropriate methods in the jersey2, okhttp-gson, resteasy libraries.@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet