[typescript-angular2] Allow lazy oauth token refresh (async access_token function) #6493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix invalid auth header zip function (needs to return the resulting header for the next observable).
- Add missing rxjs operators - Changed project name in package.json (seems like it's been overlooked after copy/pasting ng2 project) - Update ts-ng2 & ts-ng4 petstore code (seems this hasn't been done the last time)
- Generate ts-ng2 security client (also contains some previous changes)
|
@alexrashed thanks for the PR. I've changed the base to master (which is 2.3.0). Please rebase on the latest master resolve the merge conflicts. |
- Fix swagger annotations version in jaxrs-cxf-cdi pom after 2.0.0-rc1 release (maven doesn't know anything about rc versions - used 1.99 as a workaround) - Re-generated the jaxrs-cxf-cdi client
|
Argh, please get rid of a feature branch which has the same name as your upcoming version! :D EDIT: Sry, pushed a bit early... Real merge/impl coming up... |
# Conflicts: # bin/windows/typescript-angular-v2-with-npm.bat # modules/swagger-codegen/src/main/resources/typescript-angular/api.service.mustache # samples/client/petstore/typescript-angular-v2/default/api/pet.service.ts # samples/client/petstore/typescript-angular-v2/default/api/store.service.ts # samples/client/petstore/typescript-angular-v2/default/api/user.service.ts # samples/client/petstore/typescript-angular-v2/npm/api/pet.service.ts # samples/client/petstore/typescript-angular-v2/npm/api/store.service.ts # samples/client/petstore/typescript-angular-v2/npm/api/user.service.ts # samples/client/petstore/typescript-angular-v2/with-interfaces/api/pet.service.ts # samples/client/petstore/typescript-angular-v2/with-interfaces/api/store.service.ts # samples/client/petstore/typescript-angular-v2/with-interfaces/api/user.service.ts # samples/client/petstore/typescript-angular-v4/npm/api/pet.service.ts # samples/client/petstore/typescript-angular-v4/npm/api/store.service.ts # samples/client/petstore/typescript-angular-v4/npm/api/user.service.ts # samples/client/petstore/typescript-angular4/npm/configuration.ts # samples/server/petstore/jaxrs-cxf-cdi/pom.xml
|
@alexrashed Hey checkout my comment on #6846 for updating the configuration object with angular. Let me know if that works for you cause it is the best case scenario for Angular. |
alexrashed
added a commit
to alexrashed/swagger-codegen
that referenced
this pull request
Sep 13, 2017
- Startover with a new branch after pr swagger-api#6493 was created on the wrong branch - Handover authentication scheme name as well as the scopes to the accessToken function in the Configuration class - accessToken returns an Observable to allow a lazy refresh of the accessToken
6 tasks
|
As it was quite a pain to update the feature branch / merge the master in there (in comparison to the changes), I created a fresh branch / PR (#6496). |
Definitely. I'll try to do it this weekend (very busy these days ...) |
alexrashed
added a commit
to alexrashed/swagger-codegen
that referenced
this pull request
Sep 27, 2017
- Startover with a new branch after pr swagger-api#6493 was created on the wrong branch - Handover authentication scheme name as well as the scopes to the accessToken function in the Configuration class - accessToken returns an Observable to allow a lazy refresh of the accessToken
alexrashed
added a commit
to alexrashed/swagger-codegen
that referenced
this pull request
Oct 10, 2017
- Startover with a new branch after pr swagger-api#6493 was created on the wrong branch - Handover authentication scheme name as well as the scopes to the accessToken function in the Configuration class - accessToken returns an Observable to allow a lazy refresh of the accessToken
alexrashed
added a commit
to alexrashed/swagger-codegen
that referenced
this pull request
Oct 10, 2017
- Startover with a new branch after pr swagger-api#6493 was created on the wrong branch - Handover authentication scheme name as well as the scopes to the accessToken function in the Configuration class - accessToken returns an Observable to allow a lazy refresh of the accessToken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for breaking (non-backward compatible) changes.Description of the PR
Fixes #6486.
accessTokenfunction in theConfigurationas seen in [Typescript-Fetch] Support additionalproperties, Enum, Auth and more. #6130accessTokenfunction now returns anObservable<string>(allows lazy renewal using therefreshToken)Unfortunately Travis CI build fails due to some GitHub rate limits (Travis CI build). I successfully executed
mvn clean verifyin the petstore client for ts-ng2 and ts-ng4, but this only invokes the compilation and no integration tests (how can I invoke any ts-ng2/4 IT locally?). But I tested it with my own project and there are no breaking changes to the petstore projects (as they are not using theaccessTokenfunction but return a static string instead).