Skip to content

[Scala] add source folder property #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ePaul
Copy link
Contributor

@ePaul ePaul commented Sep 8, 2016

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates) → no changes at all.
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

This tries to fix #3738 by adding the sourceFolder parameter to all the scala-based languages: scala, async-scala, scalatra, akka-scala. It works analogously to how it works in the Java-generators, replacing the default src/main/scala by whatever is used in the parameter.

The new parameter is not used by the Petstore tests, therefore those did not change.

@ePaul ePaul mentioned this pull request Sep 9, 2016
3 tasks
@ePaul ePaul force-pushed the feature/#3738-add-sourceFolder-property branch from 3403185 to d3eedaf Compare September 11, 2016 18:18
@wing328 wing328 added this to the v2.2.2 milestone Sep 12, 2016
@wing328 wing328 merged commit 77d3130 into swagger-api:master Sep 12, 2016
@ePaul ePaul deleted the feature/#3738-add-sourceFolder-property branch September 12, 2016 09:16
@wing328 wing328 changed the title Feature/#3738 add source folder property [Scala] add source folder property Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Scala] respect the sourceFolder parameter when generating code
2 participants