-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] Check skipping artifiactVersion in other mustache templates, since it is not required anymore #2947
Merged
Merged
[PHP] Check skipping artifiactVersion in other mustache templates, since it is not required anymore #2947
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cce21ab
Removed printing artifactVersion if it is not set
c54b4fa
Removed printing artifactVersion if it is not set from debug information
18f32b4
Proper printing of invokerPackage in configuration debug report
3484704
Updated condition for artifactVersion check
030b1bc
added default version 1.0.0 to userAgent
8369bae
Improved formatting
794e7e4
Merge pull request #3 from swagger-api/master
ce2e994
Removed printing artifactVersion if it is not set
37264b0
Removed printing artifactVersion if it is not set from debug information
4f54e5c
Improved formatting
9f94220
Merge branch 'version-check-mustache' of github.com:mikolajprzybysz/s…
4757647
Replaced double quotes with singles
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletions
6
modules/swagger-codegen/src/main/resources/php/composer.mustache
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about replacing "\n" with PHP_EOL? (I thought you've done it via another PR already, maybe you need to rebase on the latest master)
What about remaining lines with double quote? shall we replace it with single quote as well?