Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript] Regression: after #7112 the modelPropertyNaming is ignored #7201

Closed
gennadiylitvinyuk opened this issue Dec 18, 2017 · 5 comments

Comments

@gennadiylitvinyuk
Copy link

Description

Regression: after #7112 the modelPropertyNaming is ignored

Swagger-codegen version

3.0.0-20171123.081951-8

Swagger declaration file content or url
Command line used for generation
Steps to reproduce

Use
{ "modelPropertyNaming": "original" }
in config

Related issues/PRs
Suggest a fix/enhancement

@JFCote has suggested a fix for the issue

@JFCote
Copy link
Contributor

JFCote commented Dec 18, 2017

@gennadiylitvinyuk Can you get my branch and try the fix please?
#7202

Thanks!

@gennadiylitvinyuk
Copy link
Author

@JFCote Sorry, can't compile Java right now, I just use SNAPSHOTs to generate Client in Angular 5 project

slarti-b added a commit to slarti-b/swagger-codegen that referenced this issue Dec 26, 2017
* master:
  move bvwells to go tech comm
  update current stable version in readme
  skip push snapshot to avoid error
  comment out checkstyle in circleci pom.xml
  comment out check style plugin
  Revert "update version to 2.4.0-SNAPSHOT"
  update ci config to install codegen locally
  update doc to 2.3.0
  update version to 2.4.0-SNAPSHOT
  update version to 2.3.0
  fix net35 with JsonSubTypes (swagger-api#7043)
  [Javascript] Set ES5 as default (swagger-api#7239)
  swagger-api#7201: Take the modelPropertyNaming property into account again (swagger-api#7202)
  add trenneman as elm creator
  add bvwells to go technical committee
  Video "Building an API with Swagger" (swagger-api#7237)
  [Akka-Scala] This is a fix to a bug introduced by this PR swagger-api#7172 (swagger-api#7228)
  Add Elm language - BETA (swagger-api#6947)
  bump stack resolver to lts-10.0 (swagger-api#7221)
@HermenOtter
Copy link

HermenOtter commented Dec 27, 2017

@JFCote @wing328 There seems to be more regression since the change. Parameters with containing an _ are generated incorrectly.

Swagger definition:
/sadr/v1/soorten_adres/{code_soort_adres}:
is generated to
public removeSoortenAdres(code_soort_adres: string, <..snip..> {
and
<..snip..>${encodeURIComponent(String(codeSoortAdres))}
codeSoortAdres can't be found cause it does not exist. code_soort_adres does exist.

@JFCote
Copy link
Contributor

JFCote commented Jan 4, 2018

@HermenOtter Thanks for reporting the issue and opening a bug. I will check this today and report in
issue #7262 to keep things organized.

@wing328
Copy link
Contributor

wing328 commented Jan 29, 2018

Fixed in 2.3.1 stable release.

@wing328 wing328 modified the milestones: v2.4.0, v2.3.1 Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants