Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eiffel] Enhancements to the Eiffel generator #6057

Open
2 of 6 tasks
wing328 opened this issue Jul 14, 2017 · 2 comments
Open
2 of 6 tasks

[Eiffel] Enhancements to the Eiffel generator #6057

wing328 opened this issue Jul 14, 2017 · 2 comments
Labels
Client: Eiffel Enhancement: General help wanted
Milestone
Future

Comments

@wing328
Copy link
Contributor

wing328 commented Jul 14, 2017 •
edited
Loading

Description

Here is a list of enhancements I can think of.

  • Create shell scripts, batch files to generate Eiffel Petstore samples
  • Setup CI (travis, shippable, etc) to cover the Eiffel Petstore samples.
  • Refactor part of the code into an Abstract Eiffel base class, which can be later used in Eiffel server stub generators
  • Add Eiffel Style guide to the contribution guidelines so that Eiffel contributors know what to follow in terms of code style
  • Add {{#required}} .. {{/required}} to make sure the parameters (query, form, header, body) is non-null (exmaple)
  • Add support for validation rules defined in the spec (e.g. validation for parameters in Ruby API layer)

Please feel free to reply with other suggestions.

Swagger-codegen version

Latest master

Related issues/PRs

#6036

Suggest a Fix/Enhancement

If anyone wants to work on the enhancement, please reply to let us know.

cc @jvelilla
@wing328 wing328 added this to the v2.2.3 milestone Jul 14, 2017
@wing328 wing328 modified the milestones: Future, v2.2.3 Jul 14, 2017
@jvelilla jvelilla mentioned this issue Jul 21, 2017
Merged
3 tasks
wing328 pushed a commit that referenced this issue Jul 22, 2017
@jvelilla @wing328
Enhancements to the Eiffel generator #6057 (#6138)
fa73e56 
Added shell scripts, batch files to generate Eiffel Petstore samples.
Added Setup CI (travis, shippable, etc) to cover the Eiffel Petstore samples.
Refactored part of the code into an Abstract Eiffel base class,
which can be later used in Eiffel server stub generators.
Added Eiffel Style guide to the contribution guidelines so that Eiffel contributors know what to follow in terms of code style
Fixed code generator issues.
Updated mustaches templates.
@wing328
Copy link
Contributor Author

wing328 commented Jul 22, 2017 •
edited
Loading

UPDATE: Added 2 more enhancements about required parameters and validation rules

@wing328
Copy link
Contributor Author

wing328 commented Aug 4, 2017

Various enhancements, bug fixes: #6239

@jvelilla jvelilla mentioned this issue Oct 10, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client: Eiffel Enhancement: General help wanted
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@wing328