Duplicate entries when using inheritance or composition

[yannickadam]

Description

A PR(#3935) has been opened by @j4velin regarding this problem, but I cannot find any related issue.

Using the simple definition below, we get duplicate vars for seaplane:

Also, I am unsure if the PR fully fixes the issue. Since the second call to addVars(...) will add new properties to m.allVars instead of m.vars, these properties will not be taken into account by postProcessModelProperty as it is run only on m.vars.

Swagger-codegen version

Master branch

Swagger declaration file content or url

definitions:
  plane:
    type: object
    properties:
      name:
        type: string
      length: 
        type: string

  seaplane:
    type: object
    allOf:
      - $ref: '#/definitions/plane'
      - type: object
        properties:
          other: 
            type: string

[yannickadam]

@wing328 Any chance to have your feedback on this?

[wing328]

@yannickadam I'll take a look over the weekend using the spec you provided and reply back.

[axelbodo]

In DefaultCodegen for CompositeModel.fromModel the some properties are added twice, when calling addVars, when supportsInheritance is true: from properties and from allProperties. This is the root cause of the issue which may affect readOnlyVars, readWriteVars, requiredVars and optionalVars, and is language independent.

@axelbodo