Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP][Symfony] To add PHP Symfony server generator #3486

Closed
wing328 opened this issue Jul 30, 2016 · 11 comments
Closed

[PHP][Symfony] To add PHP Symfony server generator #3486

wing328 opened this issue Jul 30, 2016 · 11 comments

Comments

@wing328
Copy link
Contributor

wing328 commented Jul 30, 2016

Description

We want to add a PHP Symfony server generator similar to what we've done for PHP Lumen, Silex, Slim.

Cloning the PHP Lumen generator is a good starting point.

If anyone is interested in making the contribution, please reply to let us know.

@Potherca
Copy link

Depending on circumstances I might be able to contribute.

@wing328
Copy link
Contributor Author

wing328 commented Aug 15, 2016

@Potherca thanks 👍

A good starting point is the Lumen Server Generator and the resource files

Let me know if you need any help.

@Potherca
Copy link

Potherca commented Feb 7, 2017

As the priorities of my current employer has shifted, my time-frame on this has changed. It'll probably be another couple of months before I get to invest time in this issue.

@wing328
Copy link
Contributor Author

wing328 commented Feb 8, 2017

@Potherca thanks for the update. That's perfectly fine. We look forward to your contribution.

In the meantime, if anyone wants to work on this, please reply to let us know.

@naelrashdeen
Copy link
Contributor

I would like to work on this. Please let me know the requirements and i might be able to contribute.

@wing328
Copy link
Contributor Author

wing328 commented May 31, 2017

@naelrashdeen thanks for offering help on this.

A good starting point is to look at the following PHP server generator and clone/copy one of them to be the base or starting point of the PHP Symfony generator.

Silex generator & resource files (templates)
Slim generator & resource files (templates)
Lumen generator & resource fils (templates)
Zend generator & resource files (templates)

Zend generator PR is another good starting point on exactly what changes are required in order to add another PHP generator to Swagger Codegen.

If you've further questions, please feel free to let us know.

@wing328
Copy link
Contributor Author

wing328 commented Jun 7, 2017

@naelrashdeen do you need any help from us? There're other useful tricks such as overriding postProcessOperations to tweak the output.

@naelrashdeen
Copy link
Contributor

@wing328 That sounds interesting. Could you please give me a couple of scenarios where that might be useful?
For now I have built a simple petstore Symfony service as a proof of concept, which I am basing my implementation of the resource files upon.

@wing328
Copy link
Contributor Author

wing328 commented Jun 8, 2017

A PHP developer who's familiar with the Symfony framework may find the generator useful if he uses the contract-first approach by first defining the OpenAPI spec and then using Swagger Codegen to generate PHP API client and server (Symfony).

ksm2 added a commit to Sponsoo/swagger-codegen that referenced this issue Jul 3, 2017
ksm2 added a commit to Sponsoo/swagger-codegen that referenced this issue Jul 3, 2017
ksm2 added a commit to Sponsoo/swagger-codegen that referenced this issue Jul 3, 2017
@ksm2
Copy link
Contributor

ksm2 commented Jul 3, 2017

Hi, as there was not much going on here and I needed this fast, I wrote a Symfony-Bundle-Generator by myself. I provided it now as a PR!

ksm2 added a commit to Sponsoo/swagger-codegen that referenced this issue Jul 4, 2017
ksm2 added a commit to Sponsoo/swagger-codegen that referenced this issue Jul 4, 2017
ksm2 added a commit to Sponsoo/swagger-codegen that referenced this issue Jul 4, 2017
ksm2 added a commit to Sponsoo/swagger-codegen that referenced this issue Jul 4, 2017
ksm2 added a commit to Sponsoo/swagger-codegen that referenced this issue Jul 4, 2017
@wing328
Copy link
Contributor Author

wing328 commented Jul 5, 2017

Closed via #5973. Thanks for the contribution by @ksm2

Future enhancements tracked via #5985

dmpliamplias pushed a commit to inventage/swagger-codegen that referenced this issue Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants