Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA, ANDROID] Use joda-time-android dependency when using android as target #3426

Open
hoeggi opened this issue Jul 20, 2016 · 4 comments
Open

Comments

@hoeggi
Copy link

hoeggi commented Jul 20, 2016

As mentioned in #3413 use 'net.danlew:android.joda:$jodatime_version' instead of "joda-time:joda-time:$jodatime_version" for performance improvements

First idea to make this work is wrapping the compile and version definition calls into
if(hasProperty('target') && target == 'android') but I'm not sure if this is the best solution for this.

Maybe someone could point me in a better direction?

@wing328
Copy link
Contributor

wing328 commented Jul 22, 2016

@hoeggi that's one way to do it.

Another one is to use CLI option is the owner of the SDK for sure knows that the SDK will be use din Android environment only.

I prefer the way you suggested by checking the target

@cbornet
Copy link
Contributor

cbornet commented Sep 20, 2016

We could also use https://github.com/JakeWharton/ThreeTenABP for "java8" dateLibrary

@cbornet
Copy link
Contributor

cbornet commented Oct 17, 2016

After checking how these libs works, I don't think this should be part of what we generate: the way to register the libs is to init them from the application context in the create() method. This is out of scope of the API client lib.
Maybe we could generate indications in the README, docs, code on how to use these libraries on android.

@wing328
Copy link
Contributor

wing328 commented Feb 17, 2017

Maybe we could generate indications in the README, docs, code on how to use these libraries on android.

Good idea to include more instructions in the doc.

If anyone from the community wants to enhancement the doc for Android API client, please reply to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants