Invalid Swift code for multipart POST with query parameters

[tomekc]

When endpoint is multipart/form-data and contains both form params and query params, like this one

/profile/{id}/photo:
    post:
      operationId: addProfilePhoto
      consumes:
        - multipart/form-data
      parameters:
        - name: id
          in: path
          required: true
          type: string
        - name: file
          in: formData
          required: true
          type: file
          minLength: 1
          maxLength: 10000000  # ~10MB
        - name: attachmentType
          in: query
          type: string
          required: true
        - name: utf8FileName
          in: query
          type: string
          required: true

Resulting code has double "falsefalse" argument in

        return requestBuilder.init(method: "POST", URLString: URLString, parameters: parameters, isBody: falsefalse)

I have found mustache template for this:

isBody: {{^queryParams}}{{^formParams}}true{{/formParams}}{{/queryParams}}{{#queryParams}}{{^secondaryParam}}false{{/secondaryParam}}{{/queryParams}}{{#formParams}}{{^secondaryParam}}false{{/secondaryParam}}{{/formParams}}

and probably end up with PR to fix :) Any suggestions are welcome, however :)

One thing I'd like to learn is what is "secondaryParam"?

[wing328]

@tomekc thanks for reporting the issue. It's not a case we've tested before and of course we would appreciate your contribution to fix it.

For secondaryParam, please refer to the discussion in #2125. Basically it's for better naming of Swift & ObjC method name.

[tomekc]

I see much room for simplification here. Just to make sure, in following snippet:

        return requestBuilder.init(method: "POST", URLString: URLString, parameters: parameters, isBody: **false**)

isBody is supposed to be true only in case of JSON encoded bodies, and false otherwise?

[wing328]

@tomekc that's how I understand it.

[tomekc]

I did the fix, but found more serious issue deeper below.
In case of POST request, query parameters are discarded (because iBody is "true" in that case).

Apparently, RequestBuilder is not designed to support that case. I will go on and submit PR.

[wing328]

@tomekc thanks for the fix.

FYI. The query parameter issue with POST request has been reported before: #2483

[wing328]

PR merged. Issue closed.