fix(apidom-ls): fix partial keys identification

Author: frantuma

packages/apidom-ls/src/config/asyncapi/config.ts

@@ -23,10 +23,20 @@ import httpMessageBindingMeta from './http-message-binding/meta';
 import kafkaMessageBindingMeta from './kafka-message-binding/meta';
 import messageMeta from './message/meta';
 import componentsMeta from './components/meta';
+import ApilintCodes from '../codes';
 
 export default {
   '*': {
-    lint: [],
+    lint: [
+      {
+        code: ApilintCodes.DUPLICATE_KEYS,
+        source: 'apilint',
+        message: 'an object cannot contain duplicate keys',
+        severity: 1,
+        linterFunction: 'apilintNoDuplicateKeys',
+        marker: 'key',
+      },
+    ],
   },
   info: infoMeta,
   contact: contactMeta,

packages/apidom-ls/src/config/codes.ts

@@ -218,6 +218,7 @@ const ApilintCodes = {
   COMPONENTS_CHANNELBINDINGS: (code += 1),
   COMPONENTS_OPERATIONBINDINGS: (code += 1),
   COMPONENTS_MESSAGEBINDINGS: (code += 1),
+  DUPLICATE_KEYS: (code += 1),
 };
 
 export default ApilintCodes;

packages/apidom-ls/src/services/completion/completion-service.ts

@@ -260,6 +260,8 @@ export class DefaultCompletionService implements CompletionService {
     }
 
     const offset = textDocument.offsetAt(position);
+    debug('doCompletion - position and offset', position, offset);
+    trace('doCompletion - text', text);
 
     // if no spec version has been set, provide completion for it anyway
     // TODO handle also JSON, must identify offset
@@ -319,6 +321,7 @@ export class DefaultCompletionService implements CompletionService {
         textModified = true;
       }
     }
+    trace('doCompletion - processedText first', processedText);
     perfStart(PerfLabels.PARSE_FIRST);
     let result = await this.settings?.documentCache?.get(
       textDocument,
@@ -331,6 +334,7 @@ export class DefaultCompletionService implements CompletionService {
     perfStart(PerfLabels.CORRECT_PARTIAL);
     debug('doCompletion - correctPartialKeys');
     processedText = correctPartialKeys(result, textDocument, isJson);
+    trace('doCompletion - processedText second', processedText);
     perfEnd(PerfLabels.CORRECT_PARTIAL);
     if (processedText) {
       debug('doCompletion - parsing processedText');

packages/apidom-ls/src/services/validation/linter-functions.ts

@@ -725,4 +725,16 @@ export const standardLinterfunctions: FunctionItem[] = [
       return true;
     },
   },
+  {
+    functionName: 'apilintNoDuplicateKeys',
+    function: (element: Element): boolean => {
+      if (element && isObject(element)) {
+        const keys = element.keys() as string[];
+        if (keys.length !== new Set(keys).size) {
+          return false;
+        }
+      }
+      return true;
+    },
+  },
 ];

packages/apidom-ls/src/utils/utils.ts

@@ -613,6 +613,7 @@ export function isPartialKey(textDocument: TextDocument, offset: number): number
     lineNonEmptyContent.length > 0 &&
     !lineNonEmptyContent.startsWith('-') &&
     !lineNonEmptyContent.endsWith(':') &&
+    !(lineNonEmptyContent.indexOf(':') > -1 && !lineNonEmptyContent.endsWith(':')) && // must not be a correct key/value
     (prevIndent < lineIndent || nextIndent < prevIndent)
   ) {
     return lineContentRange ? textDocument.offsetAt(lineContentRange.end) : undefined;