Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle value types like Option[Seq[T]] #174

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Conversation

pjfanning
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #174 (feb7aa3) into develop (4c1bc86) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage    88.20%   88.33%   +0.13%     
===========================================
  Files            3        3              
  Lines          178      180       +2     
  Branches        18       17       -1     
===========================================
+ Hits           157      159       +2     
  Misses          21       21              
Impacted Files Coverage Δ
...github/swagger/scala/converter/ErasureHelper.scala 95.45% <100.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pjfanning pjfanning merged commit 9bb35ac into develop Aug 8, 2022
@pjfanning pjfanning deleted the nested-wrappers branch August 8, 2022 09:58
@pjfanning
Copy link
Contributor Author

pjfanning commented Aug 8, 2022

@SamTheisens could you have a look at this? I think it is a necessary change for handling types like Option[Seq[T]].

[edit] I later added 60dbce2 to handle deeper nesting

@SamTheisens
Copy link
Contributor

@SamTheisens could you have a look at this? I think it is a necessary change for handling types like Option[Seq[T]].

[edit] I later added 60dbce2 to handle deeper nesting

This looks good to me 👍 . I tend to avoid optional sequences in APIs because their semantics aren't clear to me.
In theory I guess you could infinitely nest Option[Option[Option...., which isn't handled by the current code. But not sure fields like that belongs in any API :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants