Libs(Go): return response body for recover/replay #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1383 The response bodies for replay and recover missing were being ignored instead of returned. No longer! Now the bodies are propagated up, back to the caller. > [!NOTE] > This is techncially a breaking API change for the Go client.
svix-onelson
force-pushed
the
onelson/go-recover-replay-out
branch
from
5fef3c1
to
380520e
Compare
svix-jplatte
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1383
The response bodies for replay and recover missing were being ignored instead of returned.
No longer! Now the bodies are propagated up, back to the caller.
Note
This is techncially a breaking API change for the Go client.