Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minimum version of go used to build cli #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

techknowlogick
Copy link

Due to the CLI setting go.mod to go1.16 building the CLI fails due to modules requiring a newer version of go.

Errors received:

# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_darwin.go:95:8: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)

This PR is the result of bumping go.mod to go1.17, and running go mod tidy

Note: I am running into this error because I am attempting to package the CLI for NixOS, which has a specific way of building software to ensure reproducible builds.

@tasn
Copy link
Member

tasn commented Oct 23, 2023

Thanks, the team will take a look!

@techknowlogick
Copy link
Author

Hi @tasn, would you, or someone else at svix, be able to poke at this PR?

@techknowlogick
Copy link
Author

@svix-jplatte would you be able to take a look at this PR?

@svix-jplatte
Copy link
Member

Yes, just did. Unfortunately I'm not at all familiar with Go, so it's hard for me to tell whether the (seemingly tool-generated) changes are okay. Would you mind providing the steps you went through to arrive at this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants