-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Updates #1287
Comments
Thanks for your suggestions. The docs are open source as well and can be found at https://github.com/svgdotjs/svgdotjs.github.io. A PR is really welcome and will be merged asap :) |
Ok sure, just I quickly checked it out and is the version of the docs in that repository the same as live?
I didn't want to start making suggestions in code if I'm not working on the latest. |
There is a version selector at the top of the docs page. The docs currently show 3.0 by default (which is also a bug). You can check against the 3.1 version by selection it in the dropdown: https://svgjs.dev/docs/3.1/ |
Could the docs be reviewed in the following areas?
Suggestion 1 - Import Note
https://svgjs.dev/docs/3.0/getting-started/
Current:
Revised:
Where X.X.X is the version, as I don't know what version it started with if I'm using a legacy codebase that I'm updating. As many people will only hit this as a problem when they're getting bundler errors.
Suggestion 2 - Import Example
https://svgjs.dev/docs/3.0/getting-started/
Could use an actual example, rather than generic pseudo-code. Not being familiar with the whole code base, I thought that Element was going to bring in all the elements. And is there any need to alias? If so maybe explain why?
Also if you have some sample code using SVG.ClipPath() is there any way to import the element so that sample code works?
Suggestion 3 - ClipPath Defs
https://svgjs.dev/docs/3.0/shape-elements/
Whilst there is a discussion of how the constructor methods (eg. draw.clipPath() )and raw constructor ( clip = new ClipPath() ) difference here, there's no explanation in the docs of how ClipPath needs to be added to Defs. Adding something about it would be helpful, whether that's at the top of that doc page or within the ClipPath section, not sure the best place, but it's undocumented at the moment.
Bug?
When using the left nav to navigate between directly to an API (eg. SVG.Symbol and SVG.Circle) or when using the search, it doesn't go to the right heading (inline anchor) on a given page the first time. It seems to need to be clicked twice.
Benefits
The text was updated successfully, but these errors were encountered: