breaking(options): change default key-combo for svelte-inspector to alt-x #995
+49
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikg
commented
Oct 17, 2024
packages/vite-plugin-svelte-inspector/src/runtime/Inspector.svelte
Outdated
Show resolved
Hide resolved
dominikg
commented
Oct 17, 2024
| default: | ||
| return key === event.key.toLowerCase(); | ||
| return key === e.code.replace(/^Key/, '').toLowerCase() || key === e.key.toLowerCase(); |
There was a problem hiding this comment.
this change helps detecting the physical key if the modifier changed what event.key is. (eg alt-x produces a double-tilde on mac)
took the liberty to slightly refactor the is_ helpers below to all use this logic to avoid inconsistencies.
Using toLowerCase allows the user to use mixed casing in their config, Alt-X, alt-x and alt-X all work the same
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
alt-x?It should be 2 key, and usable with one hand. And most importantly not conflict with a lot of other key-combos.
The previous defaults (ctrl-shift or meta-shift) are used in many combos so they accidentally triggered the inspector eg when making a screenshot with meta-shift-3 on mac.
During my testing,
alt-xdid not trigger anything in linux, windows, mac for chrome or firefox, which should cover most users setups for development.