Skip to content

wip: enable nested optimization #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2021
Merged

wip: enable nested optimization #157

merged 6 commits into from
Sep 1, 2021

Conversation

dominikg
Copy link
Member

  • reorganized test dependencies and added cjs/esm deps

Tests are failing for pnpm test:ci:build because tests where simple-svelte dependency is used , cjs-only is added to build output without cjs to esm transform.

@dominikg dominikg requested a review from bluwy August 31, 2021 15:10
@dominikg
Copy link
Member Author

Tests fail on windows because somehow the importAnalysis plugin does not replace the cjs import in Dependency.svelte of the svelte-simple test dependency.

This works on linux and mac, so my guess is that the /@fs prefix on windows is not accounted for correctly in https://github.com/vitejs/vite/blob/c6896e80699bc05791ff1ba6ba665bc683181c28/packages/vite/src/node/plugins/resolve.ts#L482 which leads to an import url that doesn't have the &es-interop marker appended and then the import is not replaced with the optimized version.

:/

@dominikg dominikg merged commit 61a37a5 into main Sep 1, 2021
@dominikg dominikg deleted the feat/nested-optimization branch September 1, 2021 14:09
@github-actions github-actions bot mentioned this pull request Sep 1, 2021
@bluwy bluwy mentioned this pull request Mar 4, 2022
4 tasks
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants