Skip to content

Commit 8853160

Browse files
authored
ci: remove node version from cacheKey for actions/cache (#119)
1 parent 67c46ad commit 8853160

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
fail-fast: false
2222
matrix:
2323
os: [ ubuntu-latest, windows-latest, macos-latest ]
24-
node: [ 12, 14, 16 ]
24+
node: [ 14 ]
2525

2626
steps:
2727
- uses: actions/setup-node@v2
@@ -40,18 +40,18 @@ jobs:
4040
id: pnpm-store
4141
with:
4242
path: ${{ env.pnpm_store_path }}
43-
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
43+
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
4444

4545
- name: pnpm-store-fallback
4646
if: steps.pnpm-store.outputs.cache-hit != 'true'
4747
uses: actions/cache@v2
4848
id: pnpm-store-fallback
4949
with:
5050
path: ${{ env.pnpm_store_path }}
51-
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-fallback-${{ hashFiles('**/pnpm-lock.yaml') }}
51+
key: ${{ matrix.os }}-pnpm-store-fallback-${{ hashFiles('**/pnpm-lock.yaml') }}
5252
restore-keys: |
53-
${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-fallback-
54-
${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-
53+
${{ matrix.os }}-pnpm-store-fallback-
54+
${{ matrix.os }}-pnpm-store-
5555
5656
- name: install
5757
if: steps.pnpm-store.outputs.cache-hit != 'true'
@@ -84,7 +84,7 @@ jobs:
8484
id: pnpm-store
8585
with:
8686
path: ${{ env.pnpm_store_path }}
87-
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
87+
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
8888
- name: install pnpm
8989
run: npm i -g pnpm@6
9090
- name: set pnpm store-dir
@@ -119,7 +119,7 @@ jobs:
119119
id: pnpm-store
120120
with:
121121
path: ${{ env.pnpm_store_path }}
122-
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
122+
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
123123
- name: install pnpm
124124
run: npm i -g pnpm@6
125125
- name: set pnpm store-dir
@@ -151,7 +151,7 @@ jobs:
151151
id: pnpm-store
152152
with:
153153
path: ${{ env.pnpm_store_path }}
154-
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
154+
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
155155

156156
- name: install pnpm
157157
run: npm i -g pnpm@6
@@ -212,7 +212,7 @@ jobs:
212212
id: pnpm-store
213213
with:
214214
path: ${{ env.pnpm_store_path }}
215-
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
215+
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
216216
- name: install pnpm
217217
run: npm i -g pnpm@6
218218
- name: set pnpm store-dir

.github/workflows/release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,18 @@ jobs:
3434
id: pnpm-store
3535
with:
3636
path: ${{ env.pnpm_store_path }}
37-
key: ubuntu-latest-node-v14-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
37+
key: ubuntu-latest-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
3838

3939
- name: pnpm-store-fallback
4040
if: steps.pnpm-store.outputs.cache-hit != 'true'
4141
uses: actions/cache@v2
4242
id: pnpm-store-fallback
4343
with:
4444
path: ${{ env.pnpm_store_path }}
45-
key: ubuntu-latest-node-v14-pnpm-store-fallback-${{ hashFiles('**/pnpm-lock.yaml') }}
45+
key: ubuntu-latest-pnpm-store-fallback-${{ hashFiles('**/pnpm-lock.yaml') }}
4646
restore-keys: |
47-
ubuntu-latest-node-v14-pnpm-store-fallback-
48-
ubuntu-latest-node-v14-pnpm-store-
47+
ubuntu-latest-pnpm-store-fallback-
48+
ubuntu-latest-pnpm-store-
4949
5050
- name: install
5151
# install but don't run scripts, they could be evil

0 commit comments

Comments
 (0)