-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: coarse reactivity, alternative approach #16100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d2932a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Maybe |
just realised this doesn't correctly fail in cases like this... working on it <script>
let a = 1;
let b = 2;
function sum() {
return a + b;
}
</script>
<button on:click={() => a++}>a++</button>
<button on:click={() => b++}>b++</button>
<p>{a} + {b} = {sum()}</p> |
packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/utils.js
Show resolved
Hide resolved
…s/shared/utils.js
This is an alternative approach to #16073 that uses the existing
ExpressionMetadata
approach. One test is failing — will explain all this further on the other PRFixes #14351
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint