Skip to content

fix: coarse reactivity, alternative approach #16100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 17, 2025
Merged

fix: coarse reactivity, alternative approach #16100

merged 21 commits into from
Jun 17, 2025

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jun 7, 2025

This is an alternative approach to #16073 that uses the existing ExpressionMetadata approach. One test is failing — will explain all this further on the other PR

Fixes #14351

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 7, 2025

🦋 Changeset detected

Latest commit: d2932a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 7, 2025

Playground

pnpm add https://pkg.pr.new/svelte@16100

@7nik
Copy link
Contributor

7nik commented Jun 8, 2025

Maybe build_expression should apply to @render's arguments as well.
And changes to the each-index-non-null test now can be reverted.

@svelte-docs-bot
Copy link

@Rich-Harris
Copy link
Member Author

just realised this doesn't correctly fail in cases like this... working on it

<script>
  let a = 1;
  let b = 2;

  function sum() {
    return a + b;
  }
</script>

<button on:click={() => a++}>a++</button>
<button on:click={() => b++}>b++</button>

<p>{a} + {b} = {sum()}</p>

@dummdidumm dummdidumm merged commit b224c3f into main Jun 17, 2025
14 checks passed
@dummdidumm dummdidumm deleted the fix-14351-alt branch June 17, 2025 16:43
@github-actions github-actions bot mentioned this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy #await problem
3 participants