Skip to content

chore: use JSDoc type imports in more files #12239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

damianstasik
Copy link
Contributor

This PR continues the work started by Rich in #12130. I've tried to include only files that don't have any PRs open against them. One note: to avoid excessive line width, I've switched to a namespace import when there are more than five type imports from a single module. It's an arbitrary limit, but I'm happy to adjust the PR if needed.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 30, 2024

⚠️ No Changeset found

Latest commit: edbb6a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@damianstasik damianstasik marked this pull request as ready for review June 30, 2024 22:37
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! it turns out this exposes some existing fault lines (hence the test failures) which i'll address in a separate PR first

@Rich-Harris
Copy link
Member

#12255 fixes the CompileError stuff

@Rich-Harris
Copy link
Member

It seems that * as imports that make their way into the generated public types bundle don't work, for whatever reason, so I replaced those with named specifiers

@Rich-Harris Rich-Harris merged commit 84325bf into sveltejs:main Jul 2, 2024
9 checks passed
dummdidumm added a commit that referenced this pull request Sep 5, 2024
As a byproduct of #12239 some types were changed from being directly exported to indirectly exported. TypeScript is bad at following these types while generating d.ts files, so we can't do that. A check at the end of the types generation was added to prevent regressions in the future. Fixes #13128

Also removes the old types from `svelte/reactivity` which are deprecated for a while now.
dummdidumm added a commit that referenced this pull request Sep 5, 2024
As a byproduct of #12239 some types were changed from being directly exported to indirectly exported. TypeScript is bad at following these types while generating d.ts files, so we can't do that. A check at the end of the types generation was added to prevent regressions in the future. Fixes #13128

Also removes the old types from `svelte/reactivity` which are deprecated for a while now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants