-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: use JSDoc type imports in more files #12239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! it turns out this exposes some existing fault lines (hence the test failures) which i'll address in a separate PR first
#12255 fixes the |
It seems that |
As a byproduct of #12239 some types were changed from being directly exported to indirectly exported. TypeScript is bad at following these types while generating d.ts files, so we can't do that. A check at the end of the types generation was added to prevent regressions in the future. Fixes #13128 Also removes the old types from `svelte/reactivity` which are deprecated for a while now.
As a byproduct of #12239 some types were changed from being directly exported to indirectly exported. TypeScript is bad at following these types while generating d.ts files, so we can't do that. A check at the end of the types generation was added to prevent regressions in the future. Fixes #13128 Also removes the old types from `svelte/reactivity` which are deprecated for a while now.
This PR continues the work started by Rich in #12130. I've tried to include only files that don't have any PRs open against them. One note: to avoid excessive line width, I've switched to a namespace import when there are more than five type imports from a single module. It's an arbitrary limit, but I'm happy to adjust the PR if needed.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint