Skip to content

Commit cb1a76b

Browse files
committed
dont create unknown prop warnings for $$scope etc, or if component has $$props - fixes #2878
1 parent 60a2a51 commit cb1a76b

File tree

7 files changed

+41
-2
lines changed

7 files changed

+41
-2
lines changed

src/compile/render-dom/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,11 +395,11 @@ export default function dom(
395395
});
396396

397397
let unknown_props_check;
398-
if (component.compile_options.dev && writable_props.length) {
398+
if (component.compile_options.dev && !component.var_lookup.has('$$props') && writable_props.length) {
399399
unknown_props_check = deindent`
400400
const writable_props = [${writable_props.map(prop => `'${prop.export_name}'`).join(', ')}];
401401
Object.keys($$props).forEach(key => {
402-
if (!writable_props.includes(key)) console.warn(\`<${component.tag}> was created with unknown prop '\${key}'\`);
402+
if (!writable_props.includes(key) && !key.startsWith('$$')) console.warn(\`<${component.tag}> was created with unknown prop '\${key}'\`);
403403
});
404404
`;
405405
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
export let foo = undefined;
3+
4+
</script>
5+
6+
<div>{foo}</div>
7+
<div>{JSON.stringify($$props)}</div>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
export default {
2+
compileOptions: {
3+
dev: true
4+
},
5+
6+
warnings: []
7+
};
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<script>
2+
import Foo from './Foo.svelte';
3+
</script>
4+
5+
<Foo fo="sho"/>
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<script>
2+
export let answer;
3+
</script>
4+
5+
<h1>{answer}</h1>
6+
<div><slot></slot></div>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
export default {
2+
compileOptions: {
3+
dev: true
4+
},
5+
6+
warnings: []
7+
};
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<script>
2+
import Foo from './Foo.svelte';
3+
</script>
4+
5+
<Foo answer={42}>
6+
bar
7+
</Foo>

0 commit comments

Comments
 (0)