restrict further

Author: dummdidumm

packages/svelte/src/compiler/phases/2-analyze/validation.js

@@ -366,7 +366,11 @@ const validation = {
 		if (
 			node.expression.type === 'NewExpression' &&
 			node.expression.callee.type === 'Identifier' &&
-			node.expression.arguments.length === 1
+			node.expression.arguments.length === 1 &&
+			node.expression.arguments[0].type === 'ObjectExpression' &&
+			node.expression.arguments[0].properties.some(
+				(p) => p.type === 'Property' && p.key.type === 'Identifier' && p.key.name === 'target'
+			)
 		) {
 			const binding = state.scope.get(node.expression.callee.name);
 			if (binding?.kind === 'normal' && binding.declaration_kind === 'import') {

packages/svelte/tests/validator/samples/component-legacy-instantiation/input.svelte

@@ -4,7 +4,9 @@
 
 	let Buzz;
 
-	new Foo({});
+	new Foo({ target: null });
+	new Foo({}); // also a false negative to be really sure we don't get false positives
+	new Foo();
 	new Bar();
 	new Baz();
 	new Buzz();

packages/svelte/tests/validator/samples/component-legacy-instantiation/warnings.json

@@ -1,14 +1,14 @@
 [
 	{
 		"code": "legacy_component_creation",
-		"end": {
-			"column": 12,
-			"line": 7
-		},
 		"message": "Svelte 5 components are no longer classes. Instantiate them using `mount` or `hydrate` (imported from 'svelte') instead.",
 		"start": {
 			"column": 1,
 			"line": 7
+		},
+		"end": {
+			"column": 26,
+			"line": 7
 		}
 	}
 ]