Skip to content

feat: add templating mode selector #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 23, 2025
Merged

feat: add templating mode selector #1214

merged 13 commits into from
May 23, 2025

Conversation

paoloricciuti
Copy link
Member

This allow us to play around and see the output of with sveltejs/svelte#15538 and sveltejs/svelte#15599 ...when we merge something like this we can change this PR to only show the selector in those specific versions.

A note on documentation PRs

If this is a documentation PR (i.e. changing content within apps/svelte.dev/content/docs), then this is the wrong repository to make those changes. The content in this folder is synced from other repositories. Therefore, these changes should be made in their respective repositories (at https://github.com/sveltejs/svelte or https://github.com/sveltejs/kit, or example).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.

Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
svelte-dev ✅ Ready (Inspect) Visit Preview May 23, 2025 1:16pm

@Rich-Harris
Copy link
Member

The html option should be checked by default:

image

Might also be good to bump up the default height of the compiler options pane to accommodate the extra row

@paoloricciuti
Copy link
Member Author

Fixed both

@Ocean-OS
Copy link
Contributor

Found a bug where moving from one example to the other removes the option entirely, found by moving from the "hello world" example to the "reactive assignments" example

@paoloricciuti
Copy link
Member Author

Found a bug where moving from one example to the other removes the option entirely, found by moving from the "hello world" example to the "reactive assignments" example

Thanks...I also showed it with latest and that fixed the issue...if we can merge this today so i can show it on TWIS it would be great (otherwise I'll use the preview version)

@Rich-Harris Rich-Harris merged commit 3e917fb into main May 23, 2025
4 checks passed
@Rich-Harris Rich-Harris deleted the templating-mode-selector branch May 23, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants