-
-
Notifications
You must be signed in to change notification settings - Fork 23
fix: resolved issue of $props
incorrectly detected as store when using variables named after runes like $props
and props
#692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b2abfa0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
$props
was incorrectly recognized as astore when variables shared names with runes, such as $props
and props
.$props
was incorrectly recognized as astore when variables shared names with runes, such as $props
and props
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your Local
Published Instant Preview Packages:
|
$props
was incorrectly recognized as astore when variables shared names with runes, such as $props
and props
$props
incorrectly detected as store when using variables named after runes like $props
and props
e7f4446
to
6526483
Compare
… store when variables shared names with runes, such as `$props` and `props`.
6526483
to
b2abfa0
Compare
Pull Request Test Coverage Report for Build 14086358686Details
💛 - Coveralls |
I confirmed this PR fixes both issues in my project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@baseballyama Hello~ I think the fix might accidentally break and ignore the situation when the name of the store in v4 happens to be the same as the name of runes in v5. For example, the
I know I can fix my issue by refactoring the v4 store name, it just took me a little while to locate the changes causes this, so I'm leave a feedback here. |
close: sveltejs/eslint-plugin-svelte#1159
close: sveltejs/eslint-plugin-svelte#1158