Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-check: Warn: Unknown property: 'r' (scss) #2388

Open
threema-gian opened this issue Jun 3, 2024 · 5 comments
Open

svelte-check: Warn: Unknown property: 'r' (scss) #2388

threema-gian opened this issue Jun 3, 2024 · 5 comments
Labels

Comments

@threema-gian
Copy link

Describe the bug

When I use the r property (SVG circle radius) in CSS, svelte-check displays the following warning: Warn: Unknown property: 'r' (scss).

For reference:

Possibly related issues:

Reproduction

Reproducer here (built with the latest Vite + Svelte starter at the time of writing): https://github.com/threema-gian/svelte-check-unknown-property-reproducer.

Expected behaviour

Using the following CSS block should not produce any svelte-check warnings:

svg circle {
  r: 5px;
}

System Info

  • OS: Fedora 40
  • IDE: VSCode
  • Package:
    • svelte: 4.2.12
    • svelte-check: 3.6.6
    • typescript: 5.3.3
    • ...others, probably not relevant

Relevant npm script:

  • "lint:svelte": "svelte-check --workspace src/app/ --no-tsconfig --compiler-warnings \"a11y-click-events-have-key-events:ignore\""

Which package is the issue about?

svelte-check

Additional Information, eg. Screenshots

No response

@threema-gian threema-gian added the bug Something isn't working label Jun 3, 2024
@jasonlyu123 jasonlyu123 added upstream and removed bug Something isn't working labels Jun 4, 2024
@jasonlyu123
Copy link
Member

This would need support from upstream vscode-css-languageservice which pulls data from MDN. And MDN also doesn't have a dedicated page for these geometry properties.

@phobetron
Copy link

@jasonlyu123 It seems these properties should be registered in current versions of svelte-check, based on the version numbers/dates of vscode-css-languageservice and vscode-custom-data, but they're still being reported as unknown. We can see this specific property registered here.

I'm not sure whether bumping vscode-css-languageservice again would solve the issue, but I'm hopeful it may.

@jasonlyu123
Copy link
Member

Seems like it was filtered out because of the browser: none. Judging from the generation script, I think that file is from an old source, and they merged it with the data from MDN. But MDN doesn't have it. So you might need to ask MDN or ask the vscode team if they can manually update the browser capability.

@phobetron
Copy link

I've created an issue in the vscode-custom-data repository. Hopefully they'll have a solution 🤞🏻

@jasonlyu123
Copy link
Member

jasonlyu123 commented Oct 2, 2024

Oh, wait. I saw you linked the MDN page for the CSS property in the upstream issue. So MDN actually added the page recently. I didn't check it before I sent the last comment😅. Then it'll be solved after vscode-custom-data updates the dependencies and regeneate the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants