Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide access to request context via event.platform #9280

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

Rich-Harris
Copy link
Member

closes #8706. If you have adapter-vercel installed, you'll get correct typings for event.platform automatically.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@Rich-Harris
Copy link
Member Author

Lint is failing because @vercel/edge and @types/node both define a global process var, but differently. Not sure how to fix

dummdidumm
dummdidumm previously approved these changes Mar 2, 2023
@dummdidumm dummdidumm dismissed their stale review March 2, 2023 10:14

lint fails

@dummdidumm
Copy link
Member

dummdidumm commented Mar 2, 2023

Ugh, that lint is from the @vercel/edge package, type checking fails in one of the d.ts files.

@dummdidumm
Copy link
Member

My quick-fix-solution would be to copy over the needed type and remove the dependency on @vercel/edge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is awesome. I didn't know we could do this with Kit + Vercel.

@Rich-Harris Rich-Harris merged commit 2d8c63a into master Mar 2, 2023
@Rich-Harris Rich-Harris deleted the gh-8706 branch March 2, 2023 19:53
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:adapter-vercel Pertaining to the Vercel adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include FetchEvent (waitUntil) in platform data for Vercel edge adapter
4 participants