Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate space in create-svelte templates for TS demo app #8684

Conversation

tomecko
Copy link
Contributor

@tomecko tomecko commented Jan 23, 2023

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

This PR solves a minor formatting issue present in TypeScript demo app. The issue is that for packages/create-svelte/templates/default/src/routes/sverdle/+page.server.ts line 59 and packages/create-svelte/templates/default/src/routes/sverdle/game.ts line 23 produced corresponding TypeScript files have double space where closing /***/ JSDoc comment from original templates was located. I believe the only outcome caused by this PR is that TypeScript demo app in two linked locations has single space instead of a double space.

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: 9361d52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tomecko tomecko changed the title fix: remove duplicate space in create-svelte templates for TypeScript… fix: remove duplicate space in create-svelte templates for TS demo app Jan 23, 2023
@Rich-Harris Rich-Harris merged commit 4ad2752 into sveltejs:master Jan 24, 2023
@Rich-Harris
Copy link
Member

thank you!

@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants