Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Use the 'browser' platform setting for esbuild for Vercel Edge Functions #6109

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

SG60
Copy link
Contributor

@SG60 SG60 commented Aug 20, 2022

This should use the same esbuild platform setting as the Cloudflare adapter, as Vercel Edge Functions are based on Cloudflare Workers. I discovered this issue while using the Supabase JS client.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

This should use the same esbuild settings as the Cloudflare adapter, as Vercel Edge Functions are based on Cloudflare Workers.
@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2022

🦋 Changeset detected

Latest commit: a1b9d87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-vercel Patch
@sveltejs/adapter-auto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:adapter-vercel Pertaining to the Vercel adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants