fix: omit ISR data endpoints for server-only routes - #16731
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d6478bd6defa5ac039e7c332534f1a51603c8d2bOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d6478bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4cbac70 to
0e50024
Compare
|
Rebased this PR onto the latest I attempted both the adapters complete test command and its focused unit/build halves locally. In this workspace each hung without output until the command timeout/interrupt, so I did not claim a local pass for the rebased head. The previous heads GitHub CI was green; the newly pushed head is |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/adapter-bun@1.0.0-next.1 ### Minor Changes - feat: add a Bun-native adapter with static file serving and single-executable support ([#16695](#16695)) ### Patch Changes - Updated dependencies [[`9b3d195`](9b3d195), [`385d378`](385d378), [`3782448`](3782448), [`d0d3a33`](d0d3a33), [`4b7a483`](4b7a483), [`e325d7d`](e325d7d), [`4f63c79`](4f63c79)]: - @sveltejs/kit@3.0.0-next.25 ## @sveltejs/kit@3.0.0-next.25 ### Minor Changes - feat: add an `applyReroute` helper for adapters that support split serverless function deployments ([#16665](#16665)) ### Patch Changes - chore: build streamed responses from async generators ([#16847](#16847)) - fix: tweak response logging for remote requests ([#16865](#16865)) - fix: discard invalidation results when a navigation completes while they load ([#16852](#16852)) - fix: route dev-server response logging through Vite's logger so it respects `logLevel` and `customLogger` ([#16858](#16858)) - chore: read build-time config from defines on the server instead of carrying it in `options` ([#16873](#16873)) - chore: read `options` from a single module instead of passing it through the server runtime ([#16871](#16871)) ## @sveltejs/adapter-netlify@7.0.0-next.10 ### Patch Changes - fix: correctly apply `reroute` results for apps configured with split serverless functions ([#16665](#16665)) - Updated dependencies [[`9b3d195`](9b3d195), [`385d378`](385d378), [`3782448`](3782448), [`d0d3a33`](d0d3a33), [`4b7a483`](4b7a483), [`e325d7d`](e325d7d), [`4f63c79`](4f63c79)]: - @sveltejs/kit@3.0.0-next.25 ## @sveltejs/adapter-vercel@7.0.0-next.8 ### Patch Changes - fix: omit ISR data endpoints for server-only routes ([#16731](#16731)) - fix: correctly apply `reroute` results for apps configured with split serverless functions ([#16665](#16665)) - Updated dependencies [[`9b3d195`](9b3d195), [`385d378`](385d378), [`3782448`](3782448), [`d0d3a33`](d0d3a33), [`4b7a483`](4b7a483), [`e325d7d`](e325d7d), [`4f63c79`](4f63c79)]: - @sveltejs/kit@3.0.0-next.25 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
closes #12690
Server-only ISR routes do not have a page data endpoint, but the Vercel adapter currently emits a data function, prerender configuration, and routing entry for them.
This change only creates those data-specific ISR artifacts when a route has page methods. The server route main function, prerender configuration, and routing entry remain unchanged.
The build regression adds ISR to the existing API fixture and verifies that its main artifacts are present while its data artifacts are absent. It also verifies that a regular ISR page still keeps its data function and route.
Please do not delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
Changesets
Edits