Skip to content

Fix optional App.Error properties in error helper typings - #16725

Merged
dummdidumm merged 4 commits into
version-3from
copilot/fix-v3-type-error-with-error-parameters
Aug 11, 2026
Merged

Fix optional App.Error properties in error helper typings#16725
dummdidumm merged 4 commits into
version-3from
copilot/fix-v3-type-error-with-error-parameters

Conversation

Copilot AI commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

error(status, message, properties) rejected custom optional App.Error fields because the overload treated all default-compatible error shapes as having no properties.

  • Type overload

    • Enable the third argument when App.Error has any custom keys, including optional ones.
    • Keep the overload unavailable for the unaugmented default App.Error.

  • Regression coverage

    • Add a type test for an optional description field.
    • Regenerate the public declaration.
declare global {
	namespace App {
		interface Error {
			description?: string;
		}
	}
}

error(400, 'Bad request', {
	description: 'Invalid request data'
});

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 234229c:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/234229cfea7cee4da32d2a158739d788466d45ef

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16725

@changeset-bot

changeset-bot Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 234229c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI linked an issue Aug 11, 2026 that may be closed by this pull request
[v3] Type error with the new error parameters #16722
Closed
@svelte-docs-bot

svelte-docs-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-16725-svelte.vercel.app/

Copilot AI and others added 2 commits August 11, 2026 08:34
@dummdidumm
fix: allow optional error properties
6cf0680 
Co-authored-by: dummdidumm <5968653+dummdidumm@users.noreply.github.com>
@dummdidumm
fix: preserve default error overload guard
bc7eec0 
Co-authored-by: dummdidumm <5968653+dummdidumm@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix type error with the new error parameters Fix optional App.Error properties in error helper typings Aug 11, 2026
Copilot AI requested a review from dummdidumm August 11, 2026 08:38
@dummdidumm
dummdidumm marked this pull request as ready for review August 11, 2026 08:56
@dummdidumm
dummdidumm merged commit c5d0ce2 into version-3 Aug 11, 2026
26 of 27 checks passed
@dummdidumm
dummdidumm deleted the copilot/fix-v3-type-error-with-error-parameters branch August 11, 2026 08:57
@github-actions github-actions Bot mentioned this pull request Aug 11, 2026
Merged
teemingc pushed a commit that referenced this pull request Aug 11, 2026
@github-actions
Version Packages (next) (#16732)
83c6905 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to version-3, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-3` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `version-3`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @sveltejs/kit@3.0.0-next.19

### Major Changes

- breaking: move `defineParams` and associated types to
`@sveltejs/kit/params`
([#16716](#16716))

- breaking: run all errors through the `handleError` hook
([#16664](#16664))

- breaking: move `Page`, `ReadonlyURL` and `ReadonlyURLSearchParams`
from `@sveltejs/kit` to `$app/state`
([#16694](#16694))

- breaking: move `BeforeNavigate`, `OnNavigate`, `AfterNavigate`,
`Navigation`, `NavigationTarget`, `NavigationType`, `GotoOptions` and
the `Navigation*` variant types from `@sveltejs/kit` to
`$app/navigation` ([#16694](#16694))

- breaking: move `ActionResult` and `SubmitFunction` from
`@sveltejs/kit` to `$app/forms`
([#16694](#16694))

- breaking: remove `handleValidationError` and pass remote function
validation errors to `handleError` with `kind: 'validation'`
([#16672](#16672))

### Minor Changes

- feat: ignore files with + prefix if they contain test/spec/stories
([#16715](#16715))

### Patch Changes

- fix: rebuild the dev manifest when route files disappear during an
incremental update
([#16643](#16643))

- fix: externalize `@opentelemetry/api` to prevent bundler chunk
colocation between `instrumentation.server.js` and application code
([#16302](#16302))

- fix: surface prerender errors during development
([#16507](#16507))

- fix: adjust error overload for optional `App.Error` parameters
([#16725](#16725))
## @sveltejs/adapter-node@6.0.0-next.9

### Patch Changes

- fix: externalize `@opentelemetry/api` to prevent bundler chunk
colocation between `instrumentation.server.js` and application code
([#16302](#16302))
- Updated dependencies
[[`04f9ab4`](04f9ab4),
[`1e198bd`](1e198bd),
[`813726d`](813726d),
[`a115a7b`](a115a7b),
[`031ac69`](031ac69),
[`dc7442c`](dc7442c),
[`19c4478`](19c4478),
[`dc7442c`](dc7442c),
[`dc7442c`](dc7442c),
[`0b3e2b3`](0b3e2b3),
[`c5d0ce2`](c5d0ce2)]:
  - @sveltejs/kit@3.0.0-next.19

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dummdidumm dummdidumm dummdidumm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dummdidumm dummdidumm

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v3] Type error with the new error parameters

2 participants

@dummdidumm